Adjust CPU frequency scaling on desktop to run in "performance" governor #162
Conversation
If it detects the device is a laptop, it should default to the regular method of determining ac_state If the device returns any other output, it should default to ac_state=true This is my first commit on github ever. I still don't really know much about programming, but with some research, I figured it out. Couldn't fully test it because I had difficulty compiling on arch, but I think this should work in theory.
added Chassis detection for ac_state
ThePoorPilot
changed the title
AdnanHodzic
changed the title
|
@ThePoorPilot you did a great job for your first PR and I'm glad you did it for auto-cpufreq :) Change LGTM now. Since you made these changes based on @Librewish I'll make sure credit you both in release notes for 1.5.4. which will be released later on today or tomorrow. Thank you for both for your contribution! |
|
@ThePoorPilot @librewish there's a problem with using I would've made changes myself but not sure what it should return if you run it on a desktop. Running |
|
Returns "Desktop" for me |
|
@librewish could you please make a PR with these changes? If it's not too much to ask to also update auto-cpufreq-installer to also install After which I could make necessary Snap package changes and we could go ahead with 1.5.4 release. @crian @yochananmarqos could one of you please add |
|
@AdnanHodzic updated to the latest with the new dep. |
Awesome, thanks! |
This is an updated version of the commit submitted by @librewish | PR: #158 (Fixes #127)
If it detects the device is a laptop, it should default to the regular method of determining ac_state
If the device returns any other output, it should default to ac_state=true
This is my first commit on github ever. I still don't really know much about programming, but with some research, I figured it out.
Couldn't fully test it because I had difficulty running it on arch(Garuda Linux), but I think this should work in theory.
Please test it out on your thinkpad or use your more coding-oriented brain to weed out obvious problems. I got it to compile with no errors and I could run the command "auto-cpufreq", but couldn't get it to run as a system daemon.
Also, sorry if this pull request is not done exactly properly, I am not very familiar with github